(MAINT) Fix initialize of Gettext call #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #292 +/- ##
=======================================
Coverage 44.88% 44.88%
=======================================
Files 11 11
Lines 782 782
=======================================
Hits 351 351
Misses 431 431
Continue to review full report at Codecov.
|
bastelfreak
reviewed
Aug 12, 2019
.idea/workspace.xml
Outdated
| @@ -0,0 +1,962 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
I think this file should not be in this commit?
|
CLA signed by all contributors. |
|
@ThoughtCrhyme, this LGTM, thank you for your work! I'll merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bundle exec rake changelogwas failing withNoMethodError: undefined methodinitialize_config' for GettextSetup:Module` changing to initialize fixed the error.